Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default SSSP version in protocol to v1.3 #994

Merged
merged 3 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
run: verdi code create core.code.installed -n --config .github/config/code-ph.yaml --filepath-executable $(which ph.x)

- name: Setup SSSP
run: aiida-pseudo install sssp -v 1.2 -x PBEsol -p efficiency
run: aiida-pseudo install sssp -v 1.3 -x PBEsol -p efficiency

- name: Run test script
run: python .github/scripts/run_documentation_scripts.py
4 changes: 2 additions & 2 deletions docs/source/howto/calculations/pw.md
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ from ase.build import bulk
from aiida.orm import StructureData, load_code, load_group

# Load the pseudopotential family whose pseudos to use
family = load_group('SSSP/1.1/PBE/effiency')
family = load_group('SSSP/1.3/PBEsol/effiency')
structure = StructureData(ase=bulk('GaAs', 'fcc', 5.4))

builder = load_code('pw').get_builder()
Expand All @@ -226,7 +226,7 @@ from ase.build import bulk
from aiida.orm import StructureData, load_code, load_group

# Load the pseudopotential family whose pseudos to use
family = load_group('SSSP/1.1/PBE/effiency')
family = load_group('SSSP/1.3/PBEsol/effiency')
structure = StructureData(ase=bulk('GaAs', 'fcc', 5.4))

builder = load_code('pw').get_builder()
Expand Down
4 changes: 2 additions & 2 deletions docs/source/installation/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ $ pip install aiida-pseudo
```

At a minimum, at least one pseudo potential family should be installed.
We recommend using the [SSSP] with the PBEsol functional:
We recommend using the [SSSP] v1.3 with the PBEsol functional:

```console
$ aiida-pseudo install sssp -x PBEsol
$ aiida-pseudo install sssp -v 1.3 -x PBEsol
```

For more detailed information on installing other pseudo potential families, please refer to the documentation of [aiida-pseudo].
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ keywords = ['aiida', 'workflows']
requires-python = '>=3.8'
dependencies = [
'aiida_core[atomic_tools]~=2.3',
'aiida-pseudo~=1.0',
'aiida-pseudo~=1.1',
'click~=8.0',
'importlib_resources',
'jsonschema',
Expand Down
4 changes: 2 additions & 2 deletions src/aiida_quantumespresso/workflows/protocols/pw/base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ default_inputs:
meta_parameters:
conv_thr_per_atom: 0.2e-9
etot_conv_thr_per_atom: 1.e-5
pseudo_family: 'SSSP/1.2/PBEsol/efficiency'
pseudo_family: 'SSSP/1.3/PBEsol/efficiency'
pw:
metadata:
options:
Expand Down Expand Up @@ -38,7 +38,7 @@ protocols:
meta_parameters:
conv_thr_per_atom: 0.1e-9
etot_conv_thr_per_atom: 0.5e-5
pseudo_family: 'SSSP/1.2/PBEsol/precision'
pseudo_family: 'SSSP/1.3/PBEsol/precision'
pw:
parameters:
CONTROL:
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def sssp(aiida_profile, generate_upf_data):
'cutoff_rho': 240.0,
}

label = 'SSSP/1.2/PBEsol/efficiency'
label = 'SSSP/1.3/PBEsol/efficiency'
family = SsspFamily.create_from_folder(dirpath, label)

family.set_cutoffs(cutoffs, stringency, unit='Ry')
Expand Down
Loading