-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add padding for scope #331
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 75.75% 80.62% +4.87%
==========================================
Files 70 66 -4
Lines 4615 5147 +532
==========================================
+ Hits 3496 4150 +654
+ Misses 1119 997 -122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good, just a bit doc missing.
Note: we need to update three places: 1) web app, 2) widget 3) HTML template. This is not good; we need to refactor the code in the future so that we create a library for all.
Can you make a note in some issue referencing this PR or open a new issue to just keep track of it?
Yes, I created an issue |
3a5f9d2
to
e2bde09
Compare
Defines custom padding for a scope layout. The padding values are used by the ScopesPlugin to avoid node overlapping with the socket of the parent node.
Before, the
conditions
socket overlaps with task:After:
Note: we need to update three places: 1) web app, 2) widget 3) HTML template. This is not good; we need to refactor the code in the future so that we create a library for all.