Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-123): resource type and message names must align #1473

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Jan 9, 2025

Promote somewhat hidden "should" to "must" requiring that resource type names and the defining message names match.

See PR contents for Rationale

Internal bug http://b/384544423

@noahdietz noahdietz requested a review from a team as a code owner January 9, 2025 23:07
@noahdietz noahdietz requested a review from neomagus00 January 9, 2025 23:07
@noahdietz noahdietz removed the request for review from neomagus00 January 14, 2025 22:15
@noahdietz noahdietz merged commit 91c0f08 into aip-dev:master Jan 14, 2025
2 checks passed
@noahdietz noahdietz deleted the aip-123-type-name branch January 14, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants