Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of enhsp #507

Merged
merged 1 commit into from
Oct 31, 2023
Merged

new version of enhsp #507

merged 1 commit into from
Oct 31, 2023

Conversation

hstairs
Copy link
Contributor

@hstairs hstairs commented Oct 26, 2023

No description provided.

@arbimo
Copy link
Member

arbimo commented Oct 27, 2023

General question: don't we want to avoid specifying exact version. Since we (developers) are working with the master branch exact version work ok. But with the current schema, if a user wants an updated version of (e.g.) ENHSP with a bug fix, we need to cut a new release of the UP (with updated version numbers) to comply with the dependency requirements.

I use >= for versions of Aries. This can be demanding for maintaining backward compatibilty. Note that I can as well require a minimum version of the UP on Aries side.
An other less demanding option is the ~= specifier that lets pip select semantically compatible versions (https://peps.python.org/pep-0440/#compatible-release)

@hstairs hstairs marked this pull request as ready for review October 27, 2023 10:01
@hstairs
Copy link
Contributor Author

hstairs commented Oct 27, 2023

@arbimo Can you point me where in the code of Aries you enforce a minimum version of the UP in Aries?

@arbimo
Copy link
Member

arbimo commented Oct 27, 2023

@alvalentini alvalentini changed the base branch from master to handle-issue-435 October 31, 2023 13:39
@alvalentini alvalentini merged commit 4cee583 into handle-issue-435 Oct 31, 2023
7 of 8 checks passed
@alvalentini alvalentini deleted the enhsp_new_version branch October 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants