Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pddl_planner.py - added errors='ignore' in byte string decode … #620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VladKlimen
Copy link

…in solve_

I tried to run some solver and the only problem was the exception that was thrown because of encoding failure of out_err_bytes, that anyway goes to logs and not critical to lack some non-unicode characters

…in solve_

I tried to run some solver and the only problem was the exception that was thrown because of encoding failure of out_err_bytes, that anyway goes to logs and not critical to lack some non-unicode characters
@mikand
Copy link
Member

mikand commented Sep 11, 2024

Hi @VladKlimen,

thanks for this PR and for signaling the issue. I was wandering if ignoring the non-utf-8 characters is a good idea in general: Python offers other ways such as replacing: https://docs.python.org/3/library/codecs.html#error-handlers. Having pieces of outputs magically disappear from the logs might not be great, maybe replacing is a better option?

@arbimo @roeger Any thoutghs on this?

@arbimo
Copy link
Member

arbimo commented Sep 13, 2024

Hi,
I am not particularly familiar with this part of the code but in general in would agree with Andrea and favor replacing the character with UTF-8 ? (�), as supported by the python function. For me that immediately makes the problem obvious and suggests an encoding problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants