Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring autonomous processes events #646

Merged

Conversation

Ezpeon
Copy link

@Ezpeon Ezpeon commented Nov 29, 2024

I started trying to refactor some of the code in PR #629

My goal was to cleanly separate the actions from the natural transitions as they are a bit different from a modeling perspective and this was not reflected in various representations.

This is not yet complete, but any suggestions about whether what I am doing makes sense is appreciated.

@alvalentini alvalentini changed the base branch from master to autonomous_processes_events November 29, 2024 11:04
@Ezpeon Ezpeon marked this pull request as draft November 29, 2024 11:08
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 88.22496% with 67 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (6e3db94) to head (19f1e1e).
Report is 34 commits behind head on autonomous_processes_events.

Files with missing lines Patch % Lines
...d_planning/model/mixins/natural_transitions_set.py 73.07% 21 Missing ⚠️
unified_planning/model/natural_transition.py 86.88% 16 Missing ⚠️
unified_planning/model/transition.py 90.66% 14 Missing ⚠️
unified_planning/model/problem.py 83.33% 8 Missing ⚠️
unified_planning/test/test_model.py 42.85% 4 Missing ⚠️
unified_planning/io/pddl_writer.py 94.33% 3 Missing ⚠️
unified_planning/model/action.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           autonomous_processes_events     #646      +/-   ##
===============================================================
+ Coverage                        85.38%   85.41%   +0.03%     
===============================================================
  Files                              204      207       +3     
  Lines                            27653    27845     +192     
===============================================================
+ Hits                             23611    23784     +173     
- Misses                            4042     4061      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alvalentini alvalentini marked this pull request as ready for review January 16, 2025 13:29
@alvalentini alvalentini merged commit e20644a into autonomous_processes_events Jan 16, 2025
10 checks passed
@alvalentini alvalentini deleted the refactoring_autonomous_processes_events branch January 16, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants