Fix XCMP delivery issues #16
akrubase_checks.yaml
on: push
compile-and-check
17m 58s
Annotations
139 warnings
|
large size difference between variants:
node/src/cli.rs#L73
warning: large size difference between variants
--> node/src/cli.rs:73:1
|
73 | / pub enum Subcommand {
74 | | /// Key management cli utilities
75 | | #[clap(subcommand)]
76 | | Key(sc_cli::KeySubcommand),
| | -------------------------- the second-largest variant contains at least 264 bytes
... |
115 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 488 bytes
116 | | }
| |_^ the entire enum is at least 488 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
115 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
unneeded `return` statement:
node/src/chain_spec/mod.rs#L47
warning: unneeded `return` statement
--> node/src/chain_spec/mod.rs:47:9
|
47 | return RobonomicsFamily::Mainnet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
47 - return RobonomicsFamily::Mainnet;
47 + RobonomicsFamily::Mainnet
|
|
|
unneeded `return` statement:
runtime/dev/src/lib.rs#L825
warning: unneeded `return` statement
--> runtime/dev/src/lib.rs:825:13
|
825 | return (list, storage_info)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
825 | (list, storage_info)
|
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L547
warning: this operation has no effect
--> runtime/dev/src/lib.rs:547:37
|
547 | pub const MinimalBid: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L395
warning: this operation has no effect
--> runtime/dev/src/lib.rs:395:45
|
395 | pub const DataDepositPerByte: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L377
warning: this operation has no effect
--> runtime/dev/src/lib.rs:377:46
|
377 | pub const PreimageBaseDeposit: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L245
warning: this operation has no effect
--> runtime/dev/src/lib.rs:245:44
|
245 | pub const MinVestedTransfer: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L191
warning: this operation has no effect
--> runtime/dev/src/lib.rs:191:45
|
191 | pub const ExistentialDeposit: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
this function has too many arguments (9/7):
node/service/src/parachain.rs#L298
warning: this function has too many arguments (9/7)
--> node/service/src/parachain.rs:298:1
|
298 | #[sc_tracing::logging::prefix_logs_with("Parachain")]
| ^----------------------------------------------------
| |
| _in this procedural macro expansion
| |
299 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>(
300 | | parachain_config: Configuration,
301 | | polkadot_config: Configuration,
... |
339 | | bool,
340 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>,
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/parachain.rs#L254
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/parachain.rs:254:13
|
254 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/parachain.rs#L196
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/parachain.rs:196:6
|
196 | ) -> Result<
| ______^
197 | | PartialComponents<
198 | | ParachainClient<RuntimeApi>,
199 | | ParachainBackend,
... |
209 | | sc_service::Error,
210 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
this function has too many arguments (12/7):
node/service/src/parachain.rs#L120
warning: this function has too many arguments (12/7)
--> node/service/src/parachain.rs:120:1
|
120 | / pub fn build_open_consensus<RuntimeApi>(
121 | | para_id: ParaId,
122 | | lighthouse_account: AccountId,
123 | | client: Arc<ParachainClient<RuntimeApi>>,
... |
132 | | _force_authoring: bool,
133 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>
| |__________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
using `clone` on type `Option<&Registry>` which implements the `Copy` trait:
node/service/src/parachain.rs#L114
warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait
--> node/service/src/parachain.rs:114:9
|
114 | registry.clone(),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L227
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:227:6
|
227 | ) -> Result<
| ______^
228 | | (
229 | | TaskManager,
230 | | Arc<FullClient<Runtime>>,
... |
234 | | ServiceError,
235 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/dev.rs#L135
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/dev.rs:135:13
|
135 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L84
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:84:6
|
84 | ) -> Result<
| ______^
85 | | sc_service::PartialComponents<
86 | | FullClient<Runtime>,
87 | | FullBackend,
... |
101 | | ServiceError,
102 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
unused implementer of `frame_support::traits::Imbalance` that must be used:
frame/rws/src/lib.rs#L453
warning: unused implementer of `frame_support::traits::Imbalance` that must be used
--> frame/rws/src/lib.rs:453:21
|
453 | T::AuctionCurrency::burn(slash.peek());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_must_use)]` on by default
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L404
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:404:26
|
404 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L376
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:376:26
|
376 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L357
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:357:26
|
357 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L335
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:335:26
|
335 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L292
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:292:26
|
292 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L405
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:405:16
|
405 | pub fn start_auction(
| ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L377
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:377:16
|
377 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L358
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:358:16
|
358 | pub fn set_oracle(
| ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L336
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:336:16
|
336 | pub fn set_devices(
| ^^^^^^^^^^^ help: omit the `let` binding: `set_devices;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L293
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:293:16
|
293 | pub fn bid(
| ^^^ help: omit the `let` binding: `bid;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L261
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:261:16
|
261 | pub fn call(
| ^^^^ help: omit the `let` binding: `call;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L452
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:452:60
|
452 | T::AuctionCurrency::slash_reserved(&subscription_id, auction.best_price);
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L409
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:409:13
|
409 | let _ = ensure_root(origin)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L320
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:320:38
|
320 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L318
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:318:54
|
318 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L314
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:314:38
|
314 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L404
warning: use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:404:26
|
404 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L376
warning: use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:376:26
|
376 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L357
warning: use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:357:26
|
357 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L335
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:335:26
|
335 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L292
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:292:26
|
292 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L261
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:261:16
|
261 | pub fn call(
| ^^^^
|
|
use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.:
frame/rws/src/lib.rs#L235
warning: use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.
--> frame/rws/src/lib.rs:235:6
|
235 | #[pallet::generate_store(pub(super) trait Store)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/rws/src/lib.rs#L239
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/rws/src/lib.rs:239:15
|
239 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default` and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L145
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L117
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
binary comparison to literal `Option::None`:
frame/liability/src/lib.rs#L156
warning: binary comparison to literal `Option::None`
--> frame/liability/src/lib.rs:156:17
|
156 | <ReportOf<T>>::get(index) == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L145
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L117
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/liability/src/lib.rs#L108
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/liability/src/lib.rs:108:15
|
108 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default` and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
this `else { if .. }` block can be collapsed:
frame/liability/src/signed.rs#L76
warning: this `else { if .. }` block can be collapsed
--> frame/liability/src/signed.rs:76:16
|
76 | } else {
| ________________^
77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
78 | | Ok(())
79 | | } else {
80 | | Err("reserved less than expected")?
81 | | }
82 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
77 + Ok(())
78 + } else {
79 + Err("reserved less than expected")?
80 + }
|
|
|
this match could be written as a `let` statement:
frame/lighthouse/src/lib.rs#L215
warning: this match could be written as a `let` statement
--> frame/lighthouse/src/lib.rs:215:9
|
215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? {
216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))),
217 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
help: consider using a `let` statement
|
215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?;
216 + Some(Err(sp_inherents::Error::Application(Box::from(o))))
|
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L84
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:84:26
|
84 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L74
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:74:16
|
74 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^ help: omit the `let` binding: `create;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
trait `Store` is never used:
frame/digital-twin/src/lib.rs#L66
warning: trait `Store` is never used
--> frame/digital-twin/src/lib.rs:66:47
|
66 | #[pallet::generate_store(pub(super) trait Store)]
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
redundant field names in struct initialization:
frame/lighthouse/src/lib.rs#L128
warning: redundant field names in struct initialization
--> frame/lighthouse/src/lib.rs:128:17
|
128 | lighthouse: lighthouse,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L84
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:84:26
|
84 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L73
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:73:26
|
73 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L85
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:85:16
|
85 | pub fn set_source(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L74
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:74:16
|
74 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^
|
|
use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.:
frame/digital-twin/src/lib.rs#L66
warning: use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.
--> frame/digital-twin/src/lib.rs:66:6
|
66 | #[pallet::generate_store(pub(super) trait Store)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/digital-twin/src/lib.rs#L45
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/digital-twin/src/lib.rs:45:15
|
45 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default` and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
this let-binding has unit value:
frame/launch/src/lib.rs#L58
warning: this let-binding has unit value
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^ help: omit the `let` binding: `500_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/launch/src/lib.rs#L58
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/launch/src/lib.rs#L49
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/launch/src/lib.rs:49:15
|
49 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default`, `frame-benchmarking`, `runtime-benchmarks`, and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
the borrowed expression implements the required traits:
frame/datalog/src/lib.rs#L152
warning: the borrowed expression implements the required traits
--> frame/datalog/src/lib.rs:152:50
|
152 | let mut idx = DatalogIndex::<T>::get(&account);
| ^^^^^^^^ help: change this to: `account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
unused variable: `win`:
frame/datalog/src/weights.rs#L30
warning: unused variable: `win`
--> frame/datalog/src/weights.rs:30:14
|
30 | fn erase(win: u64) -> Weight {
| ^^^ help: if this is intentional, prefix it with an underscore: `_win`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/datalog/src/lib.rs#L74
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/datalog/src/lib.rs:74:15
|
74 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default`, `frame-benchmarking`, `runtime-benchmarks`, and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
large size difference between variants:
node/src/cli.rs#L73
warning: large size difference between variants
--> node/src/cli.rs:73:1
|
73 | / pub enum Subcommand {
74 | | /// Key management cli utilities
75 | | #[clap(subcommand)]
76 | | Key(sc_cli::KeySubcommand),
| | -------------------------- the second-largest variant contains at least 264 bytes
... |
115 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 488 bytes
116 | | }
| |_^ the entire enum is at least 488 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
115 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
unneeded `return` statement:
node/src/chain_spec/mod.rs#L47
warning: unneeded `return` statement
--> node/src/chain_spec/mod.rs:47:9
|
47 | return RobonomicsFamily::Mainnet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
47 - return RobonomicsFamily::Mainnet;
47 + RobonomicsFamily::Mainnet
|
|
|
unneeded `return` statement:
runtime/dev/src/lib.rs#L825
warning: unneeded `return` statement
--> runtime/dev/src/lib.rs:825:13
|
825 | return (list, storage_info)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
825 | (list, storage_info)
|
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L547
warning: this operation has no effect
--> runtime/dev/src/lib.rs:547:37
|
547 | pub const MinimalBid: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L395
warning: this operation has no effect
--> runtime/dev/src/lib.rs:395:45
|
395 | pub const DataDepositPerByte: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L377
warning: this operation has no effect
--> runtime/dev/src/lib.rs:377:46
|
377 | pub const PreimageBaseDeposit: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L245
warning: this operation has no effect
--> runtime/dev/src/lib.rs:245:44
|
245 | pub const MinVestedTransfer: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L191
warning: this operation has no effect
--> runtime/dev/src/lib.rs:191:45
|
191 | pub const ExistentialDeposit: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
this function has too many arguments (9/7):
node/service/src/parachain.rs#L298
warning: this function has too many arguments (9/7)
--> node/service/src/parachain.rs:298:1
|
298 | #[sc_tracing::logging::prefix_logs_with("Parachain")]
| ^----------------------------------------------------
| |
| _in this procedural macro expansion
| |
299 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>(
300 | | parachain_config: Configuration,
301 | | polkadot_config: Configuration,
... |
339 | | bool,
340 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>,
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/parachain.rs#L254
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/parachain.rs:254:13
|
254 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this function has too many arguments (12/7):
node/service/src/parachain.rs#L120
warning: this function has too many arguments (12/7)
--> node/service/src/parachain.rs:120:1
|
120 | / pub fn build_open_consensus<RuntimeApi>(
121 | | para_id: ParaId,
122 | | lighthouse_account: AccountId,
123 | | client: Arc<ParachainClient<RuntimeApi>>,
... |
132 | | _force_authoring: bool,
133 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>
| |__________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
using `clone` on type `Option<&Registry>` which implements the `Copy` trait:
node/service/src/parachain.rs#L114
warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait
--> node/service/src/parachain.rs:114:9
|
114 | registry.clone(),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L227
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:227:6
|
227 | ) -> Result<
| ______^
228 | | (
229 | | TaskManager,
230 | | Arc<FullClient<Runtime>>,
... |
234 | | ServiceError,
235 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/dev.rs#L135
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/dev.rs:135:13
|
135 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L84
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:84:6
|
84 | ) -> Result<
| ______^
85 | | sc_service::PartialComponents<
86 | | FullClient<Runtime>,
87 | | FullBackend,
... |
101 | | ServiceError,
102 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
unused implementer of `frame_support::traits::Imbalance` that must be used:
frame/rws/src/lib.rs#L453
warning: unused implementer of `frame_support::traits::Imbalance` that must be used
--> frame/rws/src/lib.rs:453:21
|
453 | T::AuctionCurrency::burn(slash.peek());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_must_use)]` on by default
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L404
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:404:26
|
404 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L376
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:376:26
|
376 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L357
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:357:26
|
357 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L335
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:335:26
|
335 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L292
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:292:26
|
292 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L405
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:405:16
|
405 | pub fn start_auction(
| ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L377
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:377:16
|
377 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L358
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:358:16
|
358 | pub fn set_oracle(
| ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L336
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:336:16
|
336 | pub fn set_devices(
| ^^^^^^^^^^^ help: omit the `let` binding: `set_devices;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L293
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:293:16
|
293 | pub fn bid(
| ^^^ help: omit the `let` binding: `bid;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L261
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:261:16
|
261 | pub fn call(
| ^^^^ help: omit the `let` binding: `call;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L452
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:452:60
|
452 | T::AuctionCurrency::slash_reserved(&subscription_id, auction.best_price);
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L409
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:409:13
|
409 | let _ = ensure_root(origin)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L320
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:320:38
|
320 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L318
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:318:54
|
318 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L314
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:314:38
|
314 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L312
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:312:47
|
312 | T::AuctionCurrency::unreserve(&winner, auction.best_price);
| ^^^^^^^ help: change this to: `winner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L311
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:311:54
|
311 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L404
warning: use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:404:26
|
404 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L376
warning: use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:376:26
|
376 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L357
warning: use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:357:26
|
357 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L335
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:335:26
|
335 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L292
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:292:26
|
292 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L405
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:405:16
|
405 | pub fn start_auction(
| ^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L377
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:377:16
|
377 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L358
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:358:16
|
358 | pub fn set_oracle(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L336
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:336:16
|
336 | pub fn set_devices(
| ^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L293
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:293:16
|
293 | pub fn bid(
| ^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L261
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:261:16
|
261 | pub fn call(
| ^^^^
|
|
use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.:
frame/rws/src/lib.rs#L235
warning: use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.
--> frame/rws/src/lib.rs:235:6
|
235 | #[pallet::generate_store(pub(super) trait Store)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/rws/src/lib.rs#L239
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/rws/src/lib.rs:239:15
|
239 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default` and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L145
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L117
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
binary comparison to literal `Option::None`:
frame/liability/src/lib.rs#L156
warning: binary comparison to literal `Option::None`
--> frame/liability/src/lib.rs:156:17
|
156 | <ReportOf<T>>::get(index) == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L145
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L117
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/liability/src/lib.rs#L108
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/liability/src/lib.rs:108:15
|
108 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default` and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
this `else { if .. }` block can be collapsed:
frame/liability/src/signed.rs#L76
warning: this `else { if .. }` block can be collapsed
--> frame/liability/src/signed.rs:76:16
|
76 | } else {
| ________________^
77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
78 | | Ok(())
79 | | } else {
80 | | Err("reserved less than expected")?
81 | | }
82 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
77 + Ok(())
78 + } else {
79 + Err("reserved less than expected")?
80 + }
|
|
|
this match could be written as a `let` statement:
frame/lighthouse/src/lib.rs#L215
warning: this match could be written as a `let` statement
--> frame/lighthouse/src/lib.rs:215:9
|
215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? {
216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))),
217 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
help: consider using a `let` statement
|
215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?;
216 + Some(Err(sp_inherents::Error::Application(Box::from(o))))
|
|
|
redundant field names in struct initialization:
frame/lighthouse/src/lib.rs#L128
warning: redundant field names in struct initialization
--> frame/lighthouse/src/lib.rs:128:17
|
128 | lighthouse: lighthouse,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/lighthouse/src/lib.rs#L76
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/lighthouse/src/lib.rs:76:15
|
76 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `async-trait`, `default`, `std`, and `thiserror`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L84
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:84:26
|
84 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L73
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:73:26
|
73 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L85
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:85:16
|
85 | pub fn set_source(
| ^^^^^^^^^^ help: omit the `let` binding: `set_source;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L74
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:74:16
|
74 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^ help: omit the `let` binding: `create;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
trait `Store` is never used:
frame/digital-twin/src/lib.rs#L66
warning: trait `Store` is never used
--> frame/digital-twin/src/lib.rs:66:47
|
66 | #[pallet::generate_store(pub(super) trait Store)]
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L84
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:84:26
|
84 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L73
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:73:26
|
73 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L85
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:85:16
|
85 | pub fn set_source(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L74
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:74:16
|
74 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^
|
|
use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.:
frame/digital-twin/src/lib.rs#L66
warning: use of deprecated struct `pallet::_::Store`:
Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed after July 2023.
Check https://github.com/paritytech/substrate/pull/13535 for more details.
--> frame/digital-twin/src/lib.rs:66:6
|
66 | #[pallet::generate_store(pub(super) trait Store)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/digital-twin/src/lib.rs#L45
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/digital-twin/src/lib.rs:45:15
|
45 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default` and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
this let-binding has unit value:
frame/launch/src/lib.rs#L58
warning: this let-binding has unit value
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^ help: omit the `let` binding: `500_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/launch/src/lib.rs#L58
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/launch/src/lib.rs#L49
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/launch/src/lib.rs:49:15
|
49 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default`, `frame-benchmarking`, `runtime-benchmarks`, and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
the borrowed expression implements the required traits:
frame/datalog/src/lib.rs#L152
warning: the borrowed expression implements the required traits
--> frame/datalog/src/lib.rs:152:50
|
152 | let mut idx = DatalogIndex::<T>::get(&account);
| ^^^^^^^^ help: change this to: `account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
unexpected `cfg` condition value: `try-runtime`:
frame/datalog/src/lib.rs#L74
warning: unexpected `cfg` condition value: `try-runtime`
--> frame/datalog/src/lib.rs:74:15
|
74 | #[pallet::hooks]
| ^^^^^
|
= note: expected values for `feature` are: `default`, `frame-benchmarking`, `runtime-benchmarks`, and `std`
= help: consider adding `try-runtime` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
compile-and-check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|