Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address slashes in branch names #626

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Address slashes in branch names #626

merged 1 commit into from
Nov 30, 2023

Conversation

nikhilsimha
Copy link
Contributor

Summary

Changes that come from forks tend to have slashes. We want to make sure our CI still works when there are slashes.

Why / Goal

We want to support PRs that arise from forks

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

@nikhilsimha nikhilsimha merged commit b4ebe22 into master Nov 30, 2023
@nikhilsimha nikhilsimha deleted the fork/pull branch November 30, 2023 20:15
vamseeyarla
vamseeyarla reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@vamseeyarla vamseeyarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamseeyarla vamseeyarla vamseeyarla left review comments

@hzding621 hzding621 hzding621 approved these changes

@SophieYu41 SophieYu41 SophieYu41 approved these changes

@ezvz ezvz Awaiting requested review from ezvz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhilsimha @vamseeyarla @hzding621 @SophieYu41