Replacing prints with logs #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezvz
force-pushed
the
vz--cleanup_logging
branch
3 times, most recently
from
63ae081 to
f06430c
Compare
ezvz
force-pushed
the
vz--cleanup_logging
branch
from
3695355 to
8d7fbab
Compare
ezvz
changed the title
ezvz
force-pushed
the
vz--cleanup_logging
branch
from
5bff60d to
f49fa88
Compare
|
looks like this is not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changing all printlns to user a logger.
Why / Goal
Cleaning up.
Test Plan
Reviewers
@nikhilsimha