Update MysqlSqlGenerator.kt #50861
Open
Update MysqlSqlGenerator.kt #50861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where MySQL connector wouldn't work on MariaDB as well. Writing it this way allows for cross compatibility.
|
@urban-z is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
|
|
octavia-squidington-iii
added
area/connectors
urban-z
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where MySQL connector wouldn't work on MariaDB as well. Writing it this way allows for cross compatibility.
What
Changed the MysqlSqlGenerator.kt to be cross compatible with MariaDB as well as MySQL
How
Changed from CAST to JSON_OBJECT
Review guide
MysqlSqlGenerator.ktUser Impact
Can this PR be safely reverted and rolled back?