Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iceberg] Add support for RBAC (assume aws role) auth #50957

Merged
merged 41 commits into from
Jan 9, 2025

Conversation

frifriSF59
Copy link
Contributor

What

Adding support for RBAC auth (The ability to assume a role that the user would setup on their side).
This will need to be updated to support Micronaut for our integration tests.

How

Update the current Iceberg property building process. It is reorganized to allow a user to pass an ARN that points to the role that we will need to assume.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@frifriSF59 frifriSF59 self-assigned this Jan 7, 2025
@frifriSF59 frifriSF59 requested review from a team as code owners January 7, 2025 00:18
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 5:01pm

@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Jan 7, 2025

/format-fix

Format-fix job started... Check job output.

❌ Job failed.

@frifriSF59 frifriSF59 force-pushed the frifri/rbac-iceberg-v2 branch from 21298bd to fdc56c6 Compare January 7, 2025 17:23
@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Jan 7, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (097a926)

@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Jan 7, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (eab49bb)

@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Jan 8, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (9a5395d)

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment, otherwise lgtm!

@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Jan 8, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (ee05ea6)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 9, 2025
@frifriSF59 frifriSF59 merged commit 1ed3bd3 into master Jan 9, 2025
31 checks passed
@frifriSF59 frifriSF59 deleted the frifri/rbac-iceberg-v2 branch January 9, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/iceberg-v2 connectors/destination/s3-data-lake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants