destination-s3: Use airbyte/java-connector-base:1.0.0 #50960
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
| @@ -2,12 +2,14 @@ data: | |||
| connectorSubtype: file | |||
| connectorType: destination | |||
| definitionId: 4816b78f-1489-44c1-9060-4b19d5fa9362 | |||
| dockerImageTag: 1.5.0-rc.4 | |||
| dockerImageTag: 1.5.0-rc.5 | |||
There was a problem hiding this comment.
The version should be 1.5.1. And progressive rollout should be disabled. Unless you think there's risk to not rolling this out slowly.
There was a problem hiding this comment.
@johnny-schmidt I think we can indeed not use progressive rollout for this release. But your team should coordinate to make sure we don't merge this before 1.5.0 is out - as it'll otherwise stop the progressive rollout of 1.5.0-rc.4. Wdyt?
There was a problem hiding this comment.
Actually I think the right way to proceed here is just to let you merge this as rc.5, then I will just fail that rollout, and release rc.6 on top of you.
There was a problem hiding this comment.
Actually looks like rc.5 got in ahead of you, you'll need to bump to rc.6, I'll take care of rolling the release forward.
|
@alafanechere what's the level of risk here? What exactly is different about the test image. Have you verified that this works in cloud / do you need one of us to perform that test? |
@johnny-schmidt the risk is very low. A successful build is enough IMO to consider it stable. We just changed the build logic - from a base image on which we pre-bundle some system deps / entrypoint. But we did not change the system at all. We already shipped this change smoothly on other java connectors so I feel pretty confident. |
|
Since I need to move the release forward, I'm going to go ahead and turn on automerge for this. |
|
@johnny-schmidt feel free to orchestrate the versioning and merge 👍 |
Make the connector use our official base image for java connectors