Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix --use-cdk-ref #51003

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

alafanechere
Copy link
Contributor

What

When using --use-cdk-ref we install the CDK package via a git url. Git has to be available in the build/test containers to correctly perform the install.
This PR installs Git in the container when --use-cdk-ref option is passed by the CLI.

@alafanechere alafanechere requested a review from a team as a code owner January 9, 2025 11:03
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 11:15am

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@artem1205 artem1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alafanechere alafanechere enabled auto-merge (squash) January 9, 2025 11:07
@alafanechere alafanechere merged commit 4ceaba4 into master Jan 9, 2025
30 checks passed
@alafanechere alafanechere deleted the augustin/01-09-airbyte-ci_fix_--use-cdk-ref_ branch January 9, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants