feat: update Python connector base image to v4.0.0 with Python 3.11 #52663
+226
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Update Python version from 3.10.14 to 3.11.8 - Bump base image version to 4.0.0 for major Python version change - Update Python version in sanity checks and documentation Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerOriginal prompt from [email protected]: I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
natikgadzhi
reviewed
Feb 9, 2025
natikgadzhi
reviewed
Feb 9, 2025
| @@ -70,14 +70,10 @@ async def check_python_image_has_expected_env_vars(python_image_container: dagge | |||
| """ | |||
| expected_env_vars = { | |||
| "PYTHON_VERSION", | |||
| "PYTHON_PIP_VERSION", | |||
There was a problem hiding this comment.
I have no clue where they are set, and they don't seem to be used anywhere. Code for the sake of code must die.
natikgadzhi
reviewed
Feb 9, 2025
| @@ -146,24 +146,6 @@ async def check_user_can_read_dir(container: dagger.Container, user: str, dir_pa | |||
| raise errors.SanityCheckError(f"{dir_path} is not readable by {user}.") | |||
|
|
|||
|
|
|||
| async def check_user_cant_write_dir(container: dagger.Container, user: str, dir_path: str): | |||
There was a problem hiding this comment.
Dagger started outputing exit code 1, but not throwing the exception as our code assumed. Removing the whole check because I don't see how this is useful.
natikgadzhi
reviewed
Feb 9, 2025
| @@ -79,6 +79,9 @@ poetry run mypy base_images --check-untyped-defs | |||
|
|
|||
| ## CHANGELOG | |||
|
|
|||
| ### 1.6.0 | |||
There was a problem hiding this comment.
Funny, but it seems that the changelog for the package is in a template file. Pretty insane tbh.
natikgadzhi
approved these changes
Feb 9, 2025
|
/format-fix
|
yardencarmeli
pushed a commit
that referenced
this pull request
Feb 10, 2025
…52663) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Natik Gadzhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Python connector base image to version 4.0.0, upgrading from Python 3.10 to Python 3.11.
Changes
Link to Devin run
https://app.devin.ai/sessions/7b158d1965bd493db84ea04078974ce6
Pre-merge checklist