Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable werr locally #53666

Merged
merged 1 commit into from
Feb 13, 2025
Merged

disable werr locally #53666

merged 1 commit into from
Feb 13, 2025

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Feb 12, 2025

it's incredibly annoying to comment out some code locally to test something, and have the compiler complain that there are now unused variables everywhere. Keep this behavior in CI, but disable it locally.

(we set this env var on the gradle check PR check

)

@edgao edgao requested review from a team February 12, 2025 23:27
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:32pm

Copy link
Contributor

@frifriSF59 frifriSF59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck yes. Thanks

Copy link
Contributor

@tryangul tryangul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@edgao edgao merged commit 6aacfa2 into master Feb 13, 2025
23 checks passed
@edgao edgao deleted the edgao/werr_only_on_ci branch February 13, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants