Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support having Root extend from custom trait #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

feynmanliang
Copy link

@feynmanliang feynmanliang commented May 23, 2017

Closes #6


This change is Reviewable

@feynmanliang
Copy link
Author

@aishfenton is this project still active?

@aishfenton
Copy link
Owner

Yes sorry still alive, let me review and incorporate now.

@TugdualSarazin
Copy link
Contributor

It doesn't compile if the parent object is not in the same package.

it should "support parent, and make the root element extend it" in {
    @fromSchemaResource("/simple.json", parent=Some("argus.macros.test.ParentTest"))
    object Schema

    implicitly[Schema.Root <:< argus.macros.test.ParentTest]
}
package argus.macros.test

trait ParentTest

@feynmanliang
Copy link
Author

@TugdualSarazin thanks! I'll take a look at this sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants