Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Makefiles to build without ADE. Ignore files created as part … #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davemq
Copy link
Collaborator

@davemq davemq commented Feb 5, 2018

…of the build process.

These changes get the user-mode code to build, but don't touch the kernel extension code.

@davemq davemq self-assigned this Feb 5, 2018
@akhilesh2410
Copy link
Collaborator

Hi Dave,

Makefile for kernext also need to be updated to compile kernext source code.
Please do the needful.

Thanks,
Akhilesh Verma

Copy link
Collaborator

@akhilesh2410 akhilesh2410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some review comment on this PR, Please have a look.

.include <${RULES_MK}>
#.include <${RULES_MK}>
all:
for i in $(SUBDIRS); do \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUBDIR should also have "lib/methods" directory to compile cfg_ipf utility.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add for "sbin/64" as well if required.

@@ -23,85 +23,118 @@ ILIST = ${PROGRAMS} IPFL.README
IPFL.README_IDIR = /usr/lpp/ipfl/
IDIR = /usr/sbin/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will not invoke Makefile presents in "./64" directory.
Current makefile can create 64 bit binary for all utilities,but then we will not have binary with <binary_name> and <binary_name>64 ,based on the architecture(i.e. 32 bit and 64 bit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants