-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-1332: Started implementing new aixplain programmatic api #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: Please extend the functional tests for version 2 of the SDK.
aixplain_v2/base.py
Outdated
def __init__( | ||
self, | ||
api_key: str, | ||
backend_url: str = "https://dev-platform-api.aixplain.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set production env by default
aixplain/modules/agent/__init__.py
Outdated
@@ -353,3 +353,6 @@ def deploy(self) -> None: | |||
assert self.status != AssetStatus.ONBOARDED, "Agent is already deployed." | |||
self.status = AssetStatus.ONBOARDED | |||
self.update() | |||
|
|||
def __repr__(self): | |||
return f"Agent(id={self.id}, name={self.name})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the status as well
aixplain/modules/model/__init__.py
Outdated
return f"<Model: {self.name} by {self.supplier['name']}>" | ||
except Exception: | ||
return f"<Model: {self.name} by {self.supplier}>" | ||
return f"Model(id={self.id}, name={self.name}, supplier={self.supplier})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the function
@@ -353,3 +353,6 @@ def deploy(self) -> None: | |||
assert self.status != AssetStatus.ONBOARDED, "Agent is already deployed." | |||
self.status = AssetStatus.ONBOARDED | |||
self.update() | |||
|
|||
def __repr__(self): | |||
return f"Agent(id={self.id}, name={self.name}, function={self.function})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agent has no function
properly saud. Please set the status
instead
* Adding Wallet on v2 * Adding API Key * Data asset in v2 * Fixed create in api key and dataset * Fixes in corpus, dataset and api key new factories --------- Co-authored-by: xainaz <[email protected]>
aixplain/v2/pipeline.py
Outdated
|
||
return PipelineFactory.init(name, api_key=api_key) | ||
|
||
@classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3 following methods can be removed from the Pipeline class
No description provided.