Configure jest unit tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baktun14
reviewed
Mar 15, 2024
| "test:unit": "tap --ts tests/test_*.ts", | ||
| "test:unit-snapshot": "tap --ts --snapshot tests/test_*.ts" | ||
| "test:cov": "jest --selectProjects unit functional --coverage", | ||
| "test:unit": "tap --ts tests/test_*.ts && jest --selectProjects unit", |
There was a problem hiding this comment.
Were you planning on remove/replacing tap in an another iteration?
There was a problem hiding this comment.
I'm thinking that these are at least some tests. Replicating them with jest would def take some time. So I decided it's better to leave them till we have more coverage with jest.
There was a problem hiding this comment.
Ok we can keep it for now and refactor them to jest.
ygrishajev
force-pushed
the
feature/tests
branch
from
787c335 to
7fdeec0
Compare
Redm4x
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.