-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): uses akash-api protobuf generated files instead of local ones (#184) #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to change this snapshot for tests to pass. To me it seems safe. However would like to get a confirmation
tsconfig.json
Outdated
@@ -43,7 +43,7 @@ | |||
// "noPropertyAccessFromIndexSignature": true, /* Require undeclared properties from index signatures to use element accesses. */ | |||
|
|||
/* Module Resolution Options */ | |||
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ | |||
"moduleResolution": "Node16" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow to support npm packages exports
definition natively
99e66de
to
3de8c9f
Compare
ce667cd
to
94f73e9
Compare
94f73e9
to
885d3b3
Compare
885d3b3
to
b84d0b2
Compare
@@ -83,7 +84,7 @@ | |||
"ts-loader": "^9.2.3", | |||
"ts-node": "^10.0.0", | |||
"ts-proto": "^1.104.0", | |||
"typescript": "^4.3.4", | |||
"typescript": "^4.7.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a locked version anyway
b84d0b2
to
b671dc6
Compare
…al ones (#184)
b671dc6
to
7f925ac
Compare
@@ -58,7 +58,6 @@ Object { | |||
}, | |||
], | |||
"signedBy": Object { | |||
"allOf": Array [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test a deployment with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I did the same flow as we did together
Summary
This PR updates our project's approach to managing dependencies and configurations, introduces codebase cleanups, and modifies testing frameworks. We are transitioning to using
akash-api
protobuf-generated files, reducing reliance on locally maintained versions while ensuring continued support for older client project dependencies.Changes
Protobuf Integration: Transitioned to using
akash-api
protobuf-generated files instead of local versions. This shift ensures alignment with the latest specifications and streamlines our data models.Legacy Support: Maintained local protobuf files under
v1beta1
to support client projects that depend on these older versions. This ensures compatibility and stability for existing implementations.TypeScript Configuration: Updated
tsconfig.json
to include theakash-api
package exports. This enhancement simplifies module resolution and optimizes our TypeScript environment.Code Cleanup: Eliminated unused sections of code from our codebase, enhancing readability and maintainability.
Testing with Deployment Snapshot: Updated the deployment snapshot used in our tests. Please review and confirm that the new snapshot functions correctly and meets the test scenarios' requirements in our environment.
Local Testing Setup: Temporarily included a zipped version of the
akash-api
package locally to facilitate passing CI tests. This measure will remain until the package is available on npm, allowing uninterrupted progress in development and testing.Request for Confirmation
Notes
akash-api
is available on npm. This strategy prevents external dependencies from hindering our development and testing processes.