fix(deployment): validate max deposit amount correctly

closes #603
akash-network · Jan 8, 2025 · 84a12e0 · 84a12e0
1 parent ff25f4c
commit 84a12e0
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 3 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -4,6 +4,7 @@
 **/.git
 
 **/.env.local
+**/.env.local.*
 **/.env.test
 **/.env.*.local
 **/.env.*.test

diff --git a/.gitignore b/.gitignore
@@ -71,6 +71,7 @@ apps/provider-proxy/.env
 apps/stats-web/.env
 .env.*.local
 .env.local
+.env.local.*
 .env.test
 
 # IDE files

diff --git a/apps/deploy-web/src/components/deployments/DeploymentDepositModal.tsx b/apps/deploy-web/src/components/deployments/DeploymentDepositModal.tsx
@@ -192,7 +192,7 @@ export const DeploymentDepositModal: React.FunctionComponent<DeploymentDepositMo
         category: AnalyticsCategory.DEPLOYMENTS,
         label: "Use depositor to deposit in deployment"
       });
-    } else if (depositData && amountInDenom > depositData?.balance) {
+    } else if (depositData && amount > depositData?.balance) {
       setError(`You can't deposit more than you currently have in your balance. Current balance is: ${depositData?.balance} ${depositData?.label}.`);
       return;
     }

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/docker/.env.sandbox.docker-compose-dev b/packages/docker/.env.sandbox.docker-compose-dev
@@ -4,6 +4,9 @@ UserDatabaseCS=postgres://postgres:password@db:5432/console-users
 Network=sandbox
 POSTGRES_DB_URI: postgres://postgres:password@db:5432/console-users
 
+# API
+GITHUB_TOKEN=${GITHUB_TOKEN}
+
 # Deploy Web
 API_BASE_URL: http://api:3000
 BASE_API_MAINNET_URL: http://api:3000