Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Akka 2.9.3-M3 and publish to Akka repo #1850

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Oct 6, 2023

  • and Akka HTTP 10.6.0-M2

SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
PUBLISH_USER: ${{ secrets.PUBLISH_USER }}
PUBLISH_PASSWORD: ${{ secrets.PUBLISH_PASSWORD }}

gradle-plugin:
name: Release gradle plugin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try to change the gradle plugin publishing, might not be important and I have no clue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My (limited) understanding is that the gradle plugins must come from their gradle plugin repo. Gradle users will still need the runtime and other jars from the new repo for it to work though (covered by the changes in walkthrough.md)

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
PUBLISH_USER: ${{ secrets.PUBLISH_USER }}
PUBLISH_PASSWORD: ${{ secrets.PUBLISH_PASSWORD }}

gradle-plugin:
name: Release gradle plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My (limited) understanding is that the gradle plugins must come from their gradle plugin repo. Gradle users will still need the runtime and other jars from the new repo for it to work though (covered by the changes in walkthrough.md)

@patriknw patriknw merged commit 511dbad into main Oct 9, 2023
@patriknw patriknw deleted the wip-akka-2.9.0-M3-patriknw branch October 9, 2023 07:04
@patriknw patriknw added this to the 2.4.0-M1 milestone Oct 9, 2023
johanandren pushed a commit that referenced this pull request Dec 14, 2023
* and Akka HTTP 10.6.0-M2
* -SNAPSHOT version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants