Support deserialization of job messages via SerializerWithStringManif… #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support deserialization of job messages via
SerializerWithStringManifestorSerializerwhenIncludeManifest = true.Fixes #334
Changes
This change allows for custom serializers defined with
SerializerWithStringManifestorSerializerwhenIncludeManifest = trueto have the appropriate type info passed intoFromBinary. The manifest type info is saved during job creation, allowing the deserialization process to support the manifest type hint provided by a custom serializer.This PR is related to another issue #215 but I don't think it's quite the same. From reading @object comments on the state of that issue I believe the remaining piece to solve there is allowing Akka.Hosting
.WithCustomSerializer(or hocon config) to associate a custom serializer with a specific type (other than System.Object). My PR still requires config to associate a custom serializer with System.Object, rather than a more refined type.