Add ConnectionChecker feature #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arkatufus
commented
Mar 15, 2021
Arkatufus
commented
- Add ConnectionChecker
- Add the ability to declare kafka settings directly inside of HOCON (declaring key and value serializer/deserializer is not implemented yet)
|
|
||
| var config = ConfigurationFactory.ParseString("akka.loglevel = DEBUG"); | ||
| //var config = ConfigurationFactory.ParseString("akka.loglevel = DEBUG"); | ||
| var config = ConfigurationFactory.ParseString("akka{}"); |
There was a problem hiding this comment.
Why not to keep Debug level here? I guess this is helpful for debugging by default.
| _log.Debug($"Received Stop from {Sender}, stopping"); | ||
| Context.Stop(Self); | ||
| return true; | ||
|
|
||
| case KafkaConnectionFailed kcf: | ||
| ProcessError(kcf); | ||
| Self.Tell(KafkaConsumerActorMetadata.Internal.Stop.Instance); |
There was a problem hiding this comment.
So if there is a temporary disconnect from broker, there is no other way of handling that except stopping consuming? Right now this depends on supervision strategy, you can just try to resume. ProcessError method already sending failure notification to parent (source stage), and parent may stop this actor if Dicider is configured to do that.
|
Added an issue to update documentation #191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.