-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove System.ConfigurationManager
support from .NET 6+
#7456
base: v1.6
Are you sure you want to change the base?
Remove System.ConfigurationManager
support from .NET 6+
#7456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed my changes
@@ -54,16 +54,21 @@ public static Config ParseString(string hocon) | |||
return ParseString(hocon, null); | |||
} | |||
|
|||
#if NETSTANDARD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still support this method on .NET Framework
#if NETSTANDARD | ||
var appConfig = bootstrapSetup.FlatSelect(s => s.Config).GetOrElse(ConfigurationFactory.Load()); | ||
#else | ||
var appConfig = bootstrapSetup.FlatSelect(s => s.Config).GetOrElse(ConfigurationFactory.Default()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more configuration loading from Web.config
/ App.config
on .NET 6+
System.ConfigurationManager
supportSystem.ConfigurationManager
support from .NET 6+
Changes
close #7430
System.ConfigurationManager is deprecated and legacy - it's also a major source of problems for AOT compilation.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
System.ConfigurationManager
#7430