Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made IActorTelemetry events nullable #7478

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Jan 21, 2025

Changes

And don't emit these events when they are null - aimed at fixing petabridge/phobos-issues#86

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

And don't emit these events when they are `null`
Copy link
Member Author

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed my changes

if (System.Settings.EmitActorTelemetry)
{
var actorStarted = CreateActorStartedEvent();
if(actorStarted != null)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't emit ActorStarted events if they're null


if (System.Settings.EmitActorTelemetry)
{
var stopEvent = CreateActorStoppedEvent();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't emit ActorStopped events if they're null

Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) January 21, 2025 20:33
@Aaronontheweb Aaronontheweb merged commit a64d954 into akkadotnet:dev Jan 22, 2025
10 of 12 checks passed
@Aaronontheweb Aaronontheweb deleted the optional-actor-events branch January 22, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants