Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added types to private functions, improved readability, shouldCheckProxyHeaders as separate function #38

Closed
wants to merge 1 commit into from

Conversation

satalaondrej
Copy link
Contributor

Hello,

I am proposing some minor improvements/changes

  • added argument and return types to private functions parseWildcard, parseCidr, getFirstIpAddressFromHeader
  • improved isValidIpAddress function readability
  • moved determining whether proxy headers should be checked to separate shouldCheckProxyHeaders function

@akrabat
Copy link
Owner

akrabat commented Jun 9, 2024

Replaced by #43 as we need to pass CI.

@akrabat akrabat closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants