add a test

Signed-off-by: Faeka Ansari <[email protected]>

internal/directives/json_updater.go

@@ -104,6 +104,14 @@ func (j *jsonUpdater) updateFile(workDir string, path string, changes map[string
 	}
 
 	for key, value := range changes {
+		switch value.(type) {
+		case int, int8, int16, int32, int64,
+			uint, uint8, uint16, uint32, uint64,
+			float32, float64,
+			string, bool:
+		default:
+			return fmt.Errorf("value for key %q is not a scalar type", key)
+		}
 		updatedContent, setErr := sjson.Set(string(fileContent), key, value)
 		if setErr != nil {
 			return fmt.Errorf("error setting key %q in JSON file: %w", key, setErr)
@@ -137,10 +145,6 @@ func (j *jsonUpdater) generateCommitMessage(path string, updates map[string]any)
 		switch v := value.(type) {
 		case string:
 			_, _ = commitMsg.WriteString(fmt.Sprintf("\n- %s: %q", key, v))
-		case bool:
-			_, _ = commitMsg.WriteString(fmt.Sprintf("\n- %s: \"%v\"", key, v))
-		case int, float64:
-			_, _ = commitMsg.WriteString(fmt.Sprintf("\n- %s: %v", key, v))
 		default:
 			_, _ = commitMsg.WriteString(fmt.Sprintf("\n- %s: %v", key, v))
 		}

internal/directives/json_updater_test.go

@@ -163,6 +163,39 @@ func Test_jsonUpdater_updateValuesFile(t *testing.T) {
 				assert.JSONEq(t, `{"key": "value"}`, string(content))
 			},
 		},
+		{
+			name: "preserve formatting after update",
+			valuesContent: `{
+				"key": "value",
+				"nested": {
+					"key1": "value1",
+					"key2": "value2"
+				}
+			}`,
+			changes: map[string]any{"key": "newvalue"},
+			assertions: func(t *testing.T, valuesFilePath string, err error) {
+				require.NoError(t, err)
+
+				require.FileExists(t, valuesFilePath)
+				content, err := os.ReadFile(valuesFilePath)
+				require.NoError(t, err)
+
+				updatedContent := `{
+					"key": "newvalue",
+					"nested": {
+						"key1": "value1",
+						"key2": "value2"
+					}
+				}`
+
+				assert.JSONEq(t, updatedContent, string(content))
+
+				var result map[string]any
+				err = json.Unmarshal(content, &result)
+				require.NoError(t, err)
+				assert.Equal(t, "newvalue", result["key"])
+			},
+		},
 	}
 
 	runner := &jsonUpdater{}
@@ -271,7 +304,7 @@ func Test_jsonUpdater_runPromotionStep(t *testing.T) {
 					Output: map[string]any{
 						"commitMessage": "Updated config.json\n\n" +
 							"- app.version: \"1.0.1\"\n" +
-							"- features.newFeature: \"true\"\n" +
+							"- features.newFeature: true\n" +
 							"- threshold: 100",
 					},
 				}, result)