fix(promotion): fail Promotion on validation error #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
fail-promo-on-validation-err
branch
from
6c696d8 to
e2033c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
==========================================
- Coverage 51.09% 51.08% -0.02%
==========================================
Files 282 282
Lines 21121 21125 +4
==========================================
- Hits 10792 10791 -1
- Misses 9646 9651 +5
Partials 683 683 ☔ View full report in Codecov by Sentry. |
krancour
approved these changes
Oct 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit b96a675)
|
Successfully created backport PR for |
hiddeco
added a commit
that referenced
this pull request
Oct 7, 2024
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit b96a675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2661