feat: harden image using apko and wolfi #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krancour
added
area/security
kind/chore
area/devx
area/ci-process
area/release-process
priority/high
docker
krancour
changed the title
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
krancour
force-pushed
the
krancour/harden
branch
from
c8bc661 to
ce72da2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2697 +/- ##
=======================================
Coverage 51.08% 51.08%
=======================================
Files 282 282
Lines 21125 21125
=======================================
Hits 10791 10791
Misses 9651 9651
Partials 683 683 ☔ View full report in Codecov by Sentry. |
krancour
force-pushed
the
krancour/harden
branch
2 times, most recently
from
344a560 to
bc82c92
Compare
hiddeco
reviewed
Oct 8, 2024
Signed-off-by: Kent Rancourt <[email protected]>
krancour
force-pushed
the
krancour/harden
branch
from
bc82c92 to
b732e91
Compare
Signed-off-by: Kent Rancourt <[email protected]> Co-authored-by: Hidde Beydals <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
hiddeco
reviewed
Oct 8, 2024
Signed-off-by: Kent Rancourt <[email protected]>
hiddeco
approved these changes
Oct 8, 2024
|
This can be merged after #2694. |
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2400
This PR applies a hardening strategy previously put to the test on Kargo Render in akuity/kargo-render#297
When building with
make hack-buildor via the official Actions-based CI/release processes, this will build a distroless base image using apko + wolfi and then load that into Docker and than layer the rest of Kargo on top of that. I've verified it works identically to the old image.I've also verified that changes to the Dockerfile do not disrupt our Tilt-based development workflow.
Edit: I've just realized this will break #2413. Draft until fixed.