Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: manual rolebindings for global namespaces #2934

Merged
merged 6 commits into from
Dec 12, 2024
Merged

docs: manual rolebindings for global namespaces #2934

merged 6 commits into from
Dec 12, 2024

Conversation

fykaa
Copy link
Contributor

@fykaa fykaa commented Nov 15, 2024

closes #2834

@fykaa fykaa self-assigned this Nov 15, 2024
@fykaa fykaa requested review from a team as code owners November 15, 2024 17:49
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 1048484
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67506a8a8f71ce00070826e9
😎 Deploy Preview https://deploy-preview-2934.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.90%. Comparing base (aa66473) to head (f100b88).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
+ Coverage   49.97%   50.90%   +0.93%     
==========================================
  Files         276      279       +3     
  Lines       24811    25178     +367     
==========================================
+ Hits        12400    12818     +418     
+ Misses      11724    11669      -55     
- Partials      687      691       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

krancour
krancour reviewed Nov 15, 2024
View reviewed changes
docs/docs/30-how-to-guides/20-managing-credentials.md Outdated
@@ -5,7 +5,7 @@ sidebar_label: Managing credentials

# Managing Credentials

To manage the progression of freight from stage to stage, Kargo will often
To manage the progression of `Freight` from `Stage` to `Stage`, Kargo will often
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes to uppercase here, but probably wouldn't monospace here.

Suggested change
To manage the progression of `Freight` from `Stage` to `Stage`, Kargo will often
To manage the progression of Freight from Stage to Stage, Kargo will often

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@fykaa
Copy link
Contributor Author

fykaa commented Nov 15, 2024

There is a Caution text right in the end of Global credentials section, It should give an implication of warning for enabling cluster-wide secrets

@fykaa
address reviews by @krancour
105977b 
Signed-off-by: Faeka Ansari <[email protected]>
fykaa added 2 commits November 16, 2024 00:43
@fykaa
update warning and ns-name for rb
1d0df32 
Signed-off-by: Faeka Ansari <[email protected]>
@fykaa
nit
e2a377e 
Signed-off-by: Faeka Ansari <[email protected]>
@fykaa
nit: role -> clusterrole
1048484 
Signed-off-by: Faeka Ansari <[email protected]>
@krancour krancour added this to the Live Docs milestone Dec 11, 2024
krancour
krancour approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krancour krancour added this pull request to the merge queue Dec 12, 2024
Merged via the queue into akuity:main with commit b45f77a Dec 12, 2024
19 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@fykaa @github-actions
docs: manual rolebindings for global namespaces (#2934)
89b6530 
Signed-off-by: Faeka Ansari <[email protected]>
(cherry picked from commit b45f77a)
@akuitybot akuitybot mentioned this pull request Dec 12, 2024
Merged
@akuitybot
Copy link

Successfully created backport PR for release-1.1:

diegocaspi pushed a commit to diegocaspi/kargo that referenced this pull request Dec 18, 2024
@fykaa @diegocaspi
docs: manual rolebindings for global namespaces (akuity#2934)
6b5091c 
Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Diego Caspi <[email protected]>
fykaa added a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
@fykaa
docs: manual rolebindings for global namespaces (akuity#2934)
33a8283 
Signed-off-by: Faeka Ansari <[email protected]>
fykaa added a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
@fykaa
docs: manual rolebindings for global namespaces (akuity#2934)
2dfb501 
Signed-off-by: Faeka Ansari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinlercher jkleinlercher jkleinlercher left review comments

@krancour krancour krancour approved these changes

Assignees

@fykaa fykaa

Labels
area/documentation backport/release-1.1 kind/bug priority/normal
Projects
None yet
Milestone
Live Docs
Development

Successfully merging this pull request may close these issues.

docs: need to mention need for manual rolebindings in global credential namespaces
4 participants
@fykaa @akuitybot @krancour @jkleinlercher