-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Publish kargo to brew #3011
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Faeka Ansari <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
==========================================
+ Coverage 51.08% 51.20% +0.11%
==========================================
Files 283 283
Lines 25373 25466 +93
==========================================
+ Hits 12963 13041 +78
- Misses 11712 11729 +17
+ Partials 698 696 -2 ☔ View full report in Codecov by Sentry. |
15b45e4
to
a3b357d
Compare
f566485
to
f126736
Compare
Only very minor feedback. Overall, looks great. |
Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
0faca10
to
583fda7
Compare
Signed-off-by: Faeka Ansari <[email protected]>
d5ae825
to
03897db
Compare
…ot minor release) Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Faeka Ansari <[email protected]>
56ff2a3
to
a2a6659
Compare
…r releases Signed-off-by: Faeka Ansari <[email protected]>
git add kargo.rb | ||
fi | ||
|
||
./update.sh kargo ${{ github.ref_name }} ${{ env.VERSION_SUFFIX }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about this script. It seems a bit brittle and also isn't producing formulae that pass the default CI tests included in a new tap (which I added into that repo not long ago since they were absent).
There's been previous mention of using goreleaser to publish the CLI to our homebrew tap. I've played with it a bit and it works extremely well. I am highly in favor of pursuing that further.
The one catch is that the free/open source version of goreleaser cannot publish versioned formulae, but a pro subscription isn't very expensive and I will sort out how we can get one.
Pausing onto this PR as we're considering switching to Goreleaser for the same task |
closes #2514
Added the Kargo CLI to Homebrew. The formula supports macOS (Intel and ARM) and Linux (Intel and ARM) with architecture-specific binaries for version
v1.0.3
currently.Formula can be found here: https://github.com/akuity/homebrew-tap
TODO: Give Permission to access
akuity/homebrew-tap.git
(for creating a pull request) to github-actions[bot] (GITHUB_TOKEN
)