Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): make backoff configurable for tests #3074

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Dec 5, 2024

Primarily to be able to overwrite it in tests, as the previous approach caused an unnecessary delay for the unit tests.

Primarily to be able to overwrite it in tests.

Signed-off-by: Hidde Beydals <[email protected]>
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit d89d93f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67521aa0b7eb23000803fd40
😎 Deploy Preview https://deploy-preview-3074.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.20%. Comparing base (0b548db) to head (d89d93f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/stages/regular_stages.go 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3074      +/-   ##
==========================================
- Coverage   51.23%   51.20%   -0.03%     
==========================================
  Files         283      283              
  Lines       25465    25466       +1     
==========================================
- Hits        13047    13041       -6     
- Misses      11722    11729       +7     
  Partials      696      696              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement!

@krancour krancour added this to the v1.2.0 milestone Dec 5, 2024
@hiddeco hiddeco added this pull request to the merge queue Dec 5, 2024
@hiddeco hiddeco self-assigned this Dec 5, 2024
Merged via the queue into akuity:main with commit 404422a Dec 5, 2024
21 of 23 checks passed
@hiddeco hiddeco deleted the fix-retry-cfg branch December 5, 2024 21:50
fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants