Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): app sync fix #3083

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

krancour
Copy link
Member

@krancour krancour commented Dec 6, 2024

Fixes #3082

@jessesuen, I built ghcr.io/akuity/kargo-unstable IMAGE_TAG=custom-20241207 if you want to test drive.

Signed-off-by: Kent Rancourt <[email protected]>
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit b3f6c6b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/675376cdac9a3d0008f0e225
😎 Deploy Preview https://deploy-preview-3083.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour changed the title app sync fix fix(controller): app sync fix Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.16%. Comparing base (404422a) to head (b3f6c6b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   51.20%   51.16%   -0.05%     
==========================================
  Files         283      283              
  Lines       25466    25457       -9     
==========================================
- Hits        13041    13024      -17     
- Misses      11729    11740      +11     
+ Partials      696      693       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour marked this pull request as ready for review December 7, 2024 14:32
@krancour krancour requested a review from a team as a code owner December 7, 2024 14:32
@krancour krancour added this pull request to the merge queue Dec 9, 2024
Merged via the queue into akuity:main with commit a77eedd Dec 9, 2024
26 of 28 checks passed
@krancour krancour deleted the krancour/app-sync-fix branch December 9, 2024 16:36
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
Signed-off-by: Kent Rancourt <[email protected]>
(cherry picked from commit a77eedd)
@akuitybot
Copy link

Successfully created backport PR for release-1.1:

fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: app sync not occurring for certain use case
3 participants