-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add promotion step to remove a file/directory #3086
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
==========================================
- Coverage 51.20% 51.17% -0.04%
==========================================
Files 283 287 +4
Lines 25466 25994 +528
==========================================
+ Hits 13041 13303 +262
- Misses 11729 11980 +251
- Partials 696 711 +15 ☔ View full report in Codecov by Sentry. |
This needs docs. |
@nitishfy we're looking to have 1.2 work done by 12/20 with plans to release after the winter break. Are you able to implement feedback before then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @hiddeco PTAL
Yes. The failing test case is the only blockage so far, once the CI checks are running I'll add the docs. |
I'm not considering it a blocker, but because JSON schema can be tricky to mentally parse, unit tests that assert validations work as intended would be a nice-to-have. |
if you could please update UI code as well - read this PR for reference (skip the icons) |
08de1ba
to
8cdc5d9
Compare
@nitishfy thanks for applying all the feedback! For docs, just add a new section to I would suggest the best place for this would be under the docs for the copy step. @hiddeco, apart from docs, I think the only unresolved feedback was yours. Leaving final approval up to you. |
Apart from the documentation, this also looks good to me. |
Awesome, i'll go ahead and add the docs now. |
Ready for the review. |
Signed-off-by: nitishfy <[email protected]> add symlink test case Signed-off-by: nitishfy <[email protected]> fix failing test case Signed-off-by: nitishfy <[email protected]> convert funcs to methods Signed-off-by: nitishfy <[email protected]> add test caes Signed-off-by: nitishfy <[email protected]> add ui code Signed-off-by: nitishfy <[email protected]> handle error Signed-off-by: nitishfy <[email protected]> add docs Signed-off-by: nitishfy <[email protected]> remove dot Signed-off-by: nitishfy <[email protected]>
effa8c1
to
a0dd8d5
Compare
Co-authored-by: Hidde Beydals <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitishfy thank you for all the hard work that went into this!
Signed-off-by: nitishfy <[email protected]> Signed-off-by: Kent Rancourt <[email protected]> Co-authored-by: Hidde Beydals <[email protected]> Co-authored-by: Kent Rancourt <[email protected]>
Signed-off-by: nitishfy <[email protected]> Signed-off-by: Kent Rancourt <[email protected]> Co-authored-by: Hidde Beydals <[email protected]> Co-authored-by: Kent Rancourt <[email protected]>
Fixes #2860