Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add promotion step to remove a file/directory #3086

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

nitishfy
Copy link
Member

@nitishfy nitishfy commented Dec 7, 2024

Fixes #2860

@nitishfy nitishfy requested a review from a team as a code owner December 7, 2024 12:36
Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit df9127c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6764c3272515600008f3a5d0
😎 Deploy Preview https://deploy-preview-3086.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 53.65854% with 38 lines in your changes missing coverage. Please review.

Project coverage is 51.17%. Comparing base (404422a) to head (df9127c).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/file_deleter.go 53.65% 30 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
- Coverage   51.20%   51.17%   -0.04%     
==========================================
  Files         283      287       +4     
  Lines       25466    25994     +528     
==========================================
+ Hits        13041    13303     +262     
- Misses      11729    11980     +251     
- Partials      696      711      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

krancour commented Dec 7, 2024

This needs docs.

@krancour
Copy link
Member

@nitishfy we're looking to have 1.2 work done by 12/20 with plans to release after the winter break. Are you able to implement feedback before then?

Copy link
Member Author

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @hiddeco PTAL

@nitishfy
Copy link
Member Author

@nitishfy we're looking to have 1.2 work done by 12/20 with plans to release after the winter break. Are you able to implement feedback before then?

Yes. The failing test case is the only blockage so far, once the CI checks are running I'll add the docs.

@nitishfy nitishfy requested a review from hiddeco December 17, 2024 12:43
internal/directives/file_deleter.go Outdated Show resolved Hide resolved
internal/directives/file_deleter.go Outdated Show resolved Hide resolved
internal/directives/file_deleter.go Outdated Show resolved Hide resolved
internal/directives/file_deleter.go Outdated Show resolved Hide resolved
@krancour
Copy link
Member

I'm not considering it a blocker, but because JSON schema can be tricky to mentally parse, unit tests that assert validations work as intended would be a nice-to-have.

@Marvin9
Copy link
Contributor

Marvin9 commented Dec 18, 2024

if you could please update UI code as well - read this PR for reference (skip the icons)

@nitishfy nitishfy requested review from hiddeco and krancour December 18, 2024 17:24
@krancour
Copy link
Member

@nitishfy thanks for applying all the feedback!

For docs, just add a new section to docs/docs/35-references/10-promotion-steps.md. Follow the format of existing step docs as closely as possible.

I would suggest the best place for this would be under the docs for the copy step.

@hiddeco, apart from docs, I think the only unresolved feedback was yours. Leaving final approval up to you.

@hiddeco
Copy link
Contributor

hiddeco commented Dec 19, 2024

Apart from the documentation, this also looks good to me.

@nitishfy
Copy link
Member Author

Awesome, i'll go ahead and add the docs now.

@nitishfy nitishfy requested a review from a team as a code owner December 19, 2024 10:17
@nitishfy
Copy link
Member Author

Ready for the review.

Signed-off-by: nitishfy <[email protected]>

add symlink test case

Signed-off-by: nitishfy <[email protected]>

fix failing test case

Signed-off-by: nitishfy <[email protected]>

convert funcs to methods

Signed-off-by: nitishfy <[email protected]>

add test caes

Signed-off-by: nitishfy <[email protected]>

add ui code

Signed-off-by: nitishfy <[email protected]>

handle error

Signed-off-by: nitishfy <[email protected]>

add docs

Signed-off-by: nitishfy <[email protected]>

remove dot

Signed-off-by: nitishfy <[email protected]>
@nitishfy nitishfy requested a review from hiddeco December 19, 2024 16:49
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitishfy thank you for all the hard work that went into this!

@krancour krancour enabled auto-merge December 20, 2024 01:07
@krancour krancour added this pull request to the merge queue Dec 20, 2024
Merged via the queue into akuity:main with commit 17a58cf Dec 20, 2024
15 of 17 checks passed
@nitishfy nitishfy deleted the file-deleter branch December 20, 2024 05:48
fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
Signed-off-by: nitishfy <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: Kent Rancourt <[email protected]>
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Signed-off-by: nitishfy <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: Kent Rancourt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kargo Promotion Step to Remove File and/or Directory
4 participants