Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): make app patch affect status.operationState #3104

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Dec 9, 2024

This is a follow-up to the workaround in #3069

See comment

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 6bf9321
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/675727c6ceacc80008087c72
😎 Deploy Preview https://deploy-preview-3104.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 51.14%. Comparing base (a77eedd) to head (6bf9321).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/argocd_updater.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3104      +/-   ##
==========================================
- Coverage   51.16%   51.14%   -0.03%     
==========================================
  Files         283      283              
  Lines       25457    25469      +12     
==========================================
  Hits        13026    13026              
- Misses      11738    11750      +12     
  Partials      693      693              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour enabled auto-merge December 9, 2024 17:33
@krancour krancour added this pull request to the merge queue Dec 9, 2024
Merged via the queue into akuity:main with commit 64bc742 Dec 9, 2024
24 of 26 checks passed
@krancour krancour deleted the krancour/app-patch-fix branch December 9, 2024 17:45
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@akuitybot
Copy link

Successfully created backport PR for release-1.1:

fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants