-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom PR title (#3063) #3107
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
69a17d6
to
000de72
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3107 +/- ##
==========================================
- Coverage 51.14% 51.14% -0.01%
==========================================
Files 283 283
Lines 25469 25474 +5
==========================================
+ Hits 13026 13028 +2
- Misses 11750 11752 +2
- Partials 693 694 +1 ☔ View full report in Codecov by Sentry. |
000de72
to
a099603
Compare
@krancour Please let me know your thoughts on testing here. My thinking here is that we can both assume expressions in promotion steps are evaluated properly (likely tested elsewhere), and that if I pass any title to a Git provider's |
@muenchdo correct on both counts. 😄 |
@muenchdo I think if you re-run codegen, this looks g2g. |
Signed-off-by: Dominik Münch <[email protected]>
a099603
to
4ed8dcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for this @muenchdo!
Signed-off-by: Dominik Münch <[email protected]>
Signed-off-by: Dominik Münch <[email protected]>
closes #3063