Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom PR title (#3063) #3107

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

muenchdo
Copy link
Contributor

@muenchdo muenchdo commented Dec 9, 2024

closes #3063

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 4ed8dcb
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67577b508aef7f0008c3910f
😎 Deploy Preview https://deploy-preview-3107.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.14%. Comparing base (3a1ee47) to head (4ed8dcb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/git_pr_opener.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
- Coverage   51.14%   51.14%   -0.01%     
==========================================
  Files         283      283              
  Lines       25469    25474       +5     
==========================================
+ Hits        13026    13028       +2     
- Misses      11750    11752       +2     
- Partials      693      694       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muenchdo
Copy link
Contributor Author

muenchdo commented Dec 9, 2024

@krancour Please let me know your thoughts on testing here. My thinking here is that we can both assume expressions in promotion steps are evaluated properly (likely tested elsewhere), and that if I pass any title to a Git provider's CreatePullRequest, the pull request will be created with the given title.

@krancour
Copy link
Member

krancour commented Dec 9, 2024

@muenchdo correct on both counts. 😄

@krancour
Copy link
Member

krancour commented Dec 9, 2024

@muenchdo I think if you re-run codegen, this looks g2g.

@muenchdo muenchdo marked this pull request as ready for review December 9, 2024 23:28
@muenchdo muenchdo requested review from a team as code owners December 9, 2024 23:28
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this @muenchdo!

@krancour krancour added this pull request to the merge queue Dec 9, 2024
Merged via the queue into akuity:main with commit ad9e16f Dec 9, 2024
16 of 17 checks passed
@muenchdo muenchdo deleted the custom-pr-title branch December 9, 2024 23:51
fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom PR Title
2 participants