fix(controller): do not normalize urls when searching for image creds #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
- Coverage 51.14% 51.13% -0.01%
==========================================
Files 283 283
Lines 25469 25483 +14
==========================================
+ Hits 13026 13032 +6
- Misses 11750 11757 +7
- Partials 693 694 +1 ☔ View full report in Codecov by Sentry. |
hiddeco
approved these changes
Dec 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
…#3110) Signed-off-by: Kent Rancourt <[email protected]> (cherry picked from commit 193c579)
|
Successfully created backport PR for |
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Dec 20, 2024
…akuity#3110) Signed-off-by: Kent Rancourt <[email protected]>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Jan 16, 2025
…akuity#3110) Signed-off-by: Kent Rancourt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2928
We formerly applied git repo URL and chart repo URL normalization to all repo URLs when searching for credentials because we believed it to be safe.
An edge case we'd not previously identified involved that fact that an image repo URL of the form
host:port/namecan be mistaken for an SCP-style Git URL and would thus be normalized ashost:port/name😬 and would prevent a successful match.This PR causes us to selectively normalize based on the type of credential we're searching for.