fix(auth): token renew failure #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
=======================================
Coverage 51.26% 51.26%
=======================================
Files 283 283
Lines 25563 25563
=======================================
Hits 13104 13104
Misses 11762 11762
Partials 697 697 ☔ View full report in Codecov by Sentry. |
|
I ran into this also starting just recently. |
krancour
approved these changes
Dec 11, 2024
|
Thank you for being right on top of this! |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.1
git worktree add -d .worktree/backport-3122-to-release-1.1 origin/release-1.1
cd .worktree/backport-3122-to-release-1.1
git switch --create backport-3122-to-release-1.1
git cherry-pick -x e212c2d1c45074dba8bce437c0ad1d23a5ff41fe |
|
Womp womp. Can you do this manually, @Marvin9? |
diegocaspi
pushed a commit
to diegocaspi/kargo
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Mayursinh Sarvaiya <[email protected]> Signed-off-by: Diego Caspi <[email protected]>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this was issue previously or after recent library major version bump but token renew failures went unnoticed and causing page stuck on loading spinner