Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Argo CD deep link in Promotion lists #3138

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Dec 13, 2024

fixes #3123

Screenshot 2024-12-13 at 6 24 18 PM (2)

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@Marvin9 Marvin9 requested a review from a team as a code owner December 13, 2024 22:25
@Marvin9 Marvin9 self-assigned this Dec 13, 2024
@Marvin9 Marvin9 added this to the v1.1.2 milestone Dec 13, 2024
@Marvin9 Marvin9 requested review from krancour and rpelczar December 13, 2024 22:26
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.27%. Comparing base (db17a2a) to head (d5a0c06).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3138   +/-   ##
=======================================
  Coverage   51.27%   51.27%           
=======================================
  Files         285      285           
  Lines       25706    25706           
=======================================
  Hits        13182    13182           
  Misses      11824    11824           
  Partials      700      700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from Marvin9/feat-promotion-step-plugin to main December 17, 2024 21:05
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit d5a0c06
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6761ec8f5ac71f00078d1f28
😎 Deploy Preview https://deploy-preview-3138.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Marvin9
Copy link
Contributor Author

Marvin9 commented Dec 18, 2024

@rpelczar this is hypothetically "new plugin" that we introduced in previous PR. Could you review please?

@Marvin9 Marvin9 added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit b75ef48 Dec 18, 2024
17 checks passed
@Marvin9 Marvin9 deleted the Marvin9/feat-argocd-deeplink-plugin branch December 18, 2024 14:34
fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: ArgoCD app link contains expr-lang references instead of real app name
2 participants