Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.1): fix(controller): git-push step: pull --rebase before push #3153

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

akuitybot
Copy link

Automated backport to release-1.1, triggered by a label in #3119.

Signed-off-by: Kent Rancourt <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
(cherry picked from commit 3223783)
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 57ec511
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6761b32427ecd90008ef778d
😎 Deploy Preview https://deploy-preview-3153.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 56.17978% with 78 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.1@ed2d1a6). Learn more about missing BASE report.
Report is 1 commits behind head on release-1.1.

Files with missing lines Patch % Lines
internal/controller/git/work_tree.go 8.51% 40 Missing and 3 partials ⚠️
internal/directives/simple_engine_promote.go 61.22% 18 Missing and 1 partial ⚠️
internal/directives/git_pusher.go 80.59% 11 Missing and 2 partials ⚠️
internal/directives/errors.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.1    #3153   +/-   ##
==============================================
  Coverage               ?   51.17%           
==============================================
  Files                  ?      285           
  Lines                  ?    25619           
  Branches               ?        0           
==============================================
  Hits                   ?    13110           
  Misses                 ?    11812           
  Partials               ?      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this to the v1.1.2 milestone Dec 17, 2024
@krancour krancour merged commit d282e05 into release-1.1 Dec 17, 2024
23 checks passed
@krancour krancour deleted the backport-3119-to-release-1.1 branch December 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants