-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): link to image repo correctly in Warehouse UI #3174
Conversation
Link was pointing relative to the current URL rather than to a repository. Signed-off-by: Jesper Vahlstrup Madsen <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3174 +/- ##
=======================================
Coverage 51.40% 51.40%
=======================================
Files 288 288
Lines 26100 26108 +8
=======================================
+ Hits 13416 13421 +5
- Misses 11959 11961 +2
- Partials 725 726 +1 ☔ View full report in Codecov by Sentry. |
@Sobuno Could you just fix the UI lint and then it is good to go |
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Jesper Vahlstrup Madsen <[email protected]> Signed-off-by: Mayursinh Sarvaiya <[email protected]> Co-authored-by: Mayursinh Sarvaiya <[email protected]>
Link was pointing relative to the current URL rather than to a repository. Reusing
urlForImage
function that was used for linking in the repo node already.Before (See bottom of screenshot):
Now (See bottom of screenshot):