Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warehouse regex for branch names #3234

Closed
wants to merge 3 commits into from
Closed

Conversation

tal-hason
Copy link
Contributor

the regex expression for the branch name was too limited and didn't accept branch name such as "release-0.3"

updated the regex from:

^\w+([-/]\w+)*$

to:

^\w+([-\/]\w+)*(-\d+\.\d+)?$

image

@tal-hason tal-hason requested a review from a team as a code owner January 9, 2025 08:43
@tal-hason tal-hason changed the title Fix ware house regex for branch names Fix warehouse regex for branch names Jan 9, 2025
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit fa8d8fb
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/677f8db98ec3620008cdb440
😎 Deploy Preview https://deploy-preview-3234.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.40%. Comparing base (4972b6c) to head (fa8d8fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3234   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files         288      288           
  Lines       26108    26108           
=======================================
  Hits        13421    13421           
  Misses      11961    11961           
  Partials      726      726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tal-hason tal-hason closed this Jan 9, 2025
@tal-hason
Copy link
Contributor Author

reopening from PR list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant