Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): RFC 1132 compliant name for tmp mount #3245

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Jan 10, 2025

Addresses an issue introduced (by a review suggestion) in #3218. Without this, you will run into:

spec.template.spec.volumes[0].name: Invalid value: "tmpData": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is [a-z0-9]([-a-z0-9]*[a-z0-9])?)

@hiddeco hiddeco added this to the v1.2.0 milestone Jan 10, 2025
@hiddeco hiddeco self-assigned this Jan 10, 2025
@hiddeco hiddeco requested a review from a team as a code owner January 10, 2025 21:15
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 4c8a7c1
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67818e02776b8c0008516e9b
😎 Deploy Preview https://deploy-preview-3245.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.55%. Comparing base (6abfa3f) to head (4c8a7c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3245   +/-   ##
=======================================
  Coverage   51.55%   51.55%           
=======================================
  Files         288      288           
  Lines       26188    26188           
=======================================
  Hits        13502    13502           
  Misses      11960    11960           
  Partials      726      726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco added this pull request to the merge queue Jan 10, 2025
Merged via the queue into akuity:main with commit 1313f03 Jan 10, 2025
24 checks passed
@hiddeco hiddeco deleted the fix-mount-name branch January 10, 2025 21:30
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants