feat: add ability to control semantics for Freight being made available to a Stage #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…n all upstream Stages Signed-off-by: Aidan Rowe <[email protected]>
aidan-canva
force-pushed
the
feat-freight-availability-all-semantic
branch
from
c6645f0 to
bfa3654
Compare
|
FYI @krancour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3207
Adds concept of 'availability strategy' to a Freight Request to allow users to control the semantics used to determine if (verified) Freight is made available to a stage.
Default behavior is to make a Freight available if 'any' of the upstream Stages have verified it. This is backwards compatible with the current state of behavior. Users can explicitly configure
UpstreamAny(default behavior) orUpstreamAll(enums) as possible values.UpstreamAllwill only make Freight available if all of the configure upstream Stages have verified it. An enum was chosen over a boolean as it is possible other option could be implemented in the future (ie, promote when a majority of upstream have verified the Freight).This condition is applied on-top of existing Freight Request controls, such as the recently added minimum bake time control. For that reason, perhaps its better suited to sit closer to
FreightSourceswhere theRequiredSoakTimeis configured.