Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nga Tran <[email protected]>
  • Loading branch information
alamb and NGA-TRAN authored Dec 20, 2023
1 parent 66e212c commit 324cb10
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions datafusion/core/src/physical_optimizer/pruning.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,7 @@ mod tests {
self
}

/// Add contained informaation.
/// Add contained information.
pub fn with_contained(
mut self,
values: impl IntoIterator<Item = ScalarValue>,
Expand Down Expand Up @@ -1331,7 +1331,7 @@ mod tests {
self
}

/// Add contained informaation for the specified columm.
/// Add contained information for the specified columm.
fn with_contained(
mut self,
name: impl Into<String>,
Expand Down Expand Up @@ -2692,7 +2692,7 @@ mod tests {
Some(true),
Some(true),
Some(true),
// container 6,7,8 known ro contain neither "foo" and "bar"
// container 6,7,8 known to contain neither "foo" and "bar"
Some(false),
Some(false),
Some(false),
Expand Down Expand Up @@ -2932,8 +2932,8 @@ mod tests {
prune_with_expr(
col("s1").not_eq(lit("foo")).and(
col("s2")
.not_eq(lit("bar"))
.or(col("s2").not_eq(lit("baz"))),
.eq(lit("bar"))
.or(col("s2").eq(lit("baz"))),
),
&schema,
&statistics,
Expand Down Expand Up @@ -3057,7 +3057,7 @@ mod tests {

// i = 0 OR s = 'foo'
prune_with_expr(
col("i").eq(lit(0)).or(col("s").not_eq(lit("foo"))),
col("i").eq(lit(0)).or(col("s").eq(lit("foo"))),
&schema,
&statistics,
// in theory could rule out containers if we had min/max values for
Expand Down

0 comments on commit 324cb10

Please sign in to comment.