Added draw of rectangle in 'onEmptyViewClicked' and listener if the same date is clicked twice. (Similar to Google Calendar App). #160
Conversation
…ame date is clicked twice. (Similar to Google Calendar App).
…ame date is clicked twice. (Similar to Google Calendar App).
…ame date is clicked twice. (Similar to Google Calendar App).
…ame date is clicked twice. (Similar to Google Calendar App).
| Calendar day = (Calendar) mToday.clone(); | ||
| day.add(Calendar.HOUR, 6); | ||
| int leftDaysWithGaps = (int) -(Math.ceil(mCurrentOrigin.x / (mWidthPerDay + mColumnGap))); | ||
| //iterate thru days |
There was a problem hiding this comment.
(through)
Please correct english 😄 (feature is cool, though)
|
That's a cool feature but I do not think it has to be activated by default. I would love to have a boolean to activate or deactivate this mode directly in the XML (something like Cool work 🎉 👍 ❗ |
|
Thanks! 😄 I worked on it a couple days ago, wanted to share it with you guys. |
|
Yes that your code only works if I activate the feature (so you basically parse the |
|
Indeed, this should be an optional feature. |
|
Any chance of this getting updated and merged -- it's a nice optional feature, but looks like it was developed on a much older revision and some updates might be necessary? |
|
Hey guys sorry about that been busy lately.. Will try to work on this feature this week.. |
|
@asolis90 @jhoobergs is also working on this. He has a recent version. |
|
@asolis90 Here is my fork: https://github.com/Quivr/Android-Week-View/tree/Add_events |
|
hey guys, don't think i forgot about this feature.. lol Today I spent some time in it.. Its almost done and fully functional 😄 |
|
@asolis90 @jhoobergs already has a working version. (One that's even in production already). |
|
But is @jhoobergs planning to submit a pull request for it? On Mon, May 9, 2016 at 3:17 AM, Jens Claes [email protected] wrote:
|
|
I have tested his version and it is not the desired way to go about doing this. The empty event is conflicting with other events when its drawn, also the empty event rectangle should be drawn hourly and is not being handled correctly. I'll close this PR since its off track and open a new one. Please review my changes and if possible give some feedback. |
|
ref #321 |
* fix for concurrency bug * minimized diff * used CopyOnWriteArrayList Co-authored-by: Felix Felten <[email protected]>
Added functionality to draw rectangle in 'onEmptyViewClicked' and listener if the same date is clicked twice. Also added option for it to change the color of the rectangle.
