Skip to content
This repository has been archived by the owner on May 16, 2020. It is now read-only.

avoid just spinning forever when selected quality doesn't exist #293

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

rakslice
Copy link
Collaborator

Addresses the spinning forever when there is no stream for the selected quality mentioned in #292

  • if the selected stream or VOD doesn't have the quality from the settings (e.g. the last quality manually set with the dropdown), try "source" instead
  • if for whatever reason we still get a null URL, don't try playing the null UR, and log an error

…lity is not available try source; don't try to play an empty URL, log an error instead
@alamminsalo alamminsalo merged commit b7360bb into alamminsalo:master Feb 18, 2020
@QuLogic
Copy link

QuLogic commented Mar 24, 2020

Please, can you make a new release with this fix? It's reeaally annoying, because the quality dropdown doesn't even show up.

@rakslice
Copy link
Collaborator Author

rakslice commented Mar 24, 2020

Note that you if you want to try a commit on windows without waiting for a new release, you can just go to the Appveyor automated build job (https://ci.appveyor.com/project/alamminsalo/orion/branch/master -- you can find it from the Build Passing button in the Readme), pick x86 or x64, and go to the artifacts section and download the exe (which is the installer) from that build.

@rakslice
Copy link
Collaborator Author

But hopefully @alamminsalo can put up a new release soon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants