Add quick and dirty support for specifying desired linking mode #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberdine
commented
Apr 16, 2023
| if test -z "$default_mode"; then | ||
| echo "Something is wrong with the llvm-config command provided." | ||
| exit 1 | ||
| fi | ||
|
|
||
| base_cflags=$(llvm_config --cflags) | ||
| ldflags="$(llvm_config --ldflags) -lstdc++" | ||
| ldflags="$(pkg-config --libs-only-L libzstd) $(llvm_config --ldflags) -lstdc++" |
There was a problem hiding this comment.
This seems unrelated, but I needed it for linking to libllvm in static mode to succeed.
There was a problem hiding this comment.
Is this a LLVM 16 thing? Wouldn't llvm-config --system-libs work here instead?
There was a problem hiding this comment.
llvm-config --link-static --system-libs does include zstd, giving -lm -lz -lzstd -lcurses -lxml2, so that looks like the way to go when I get back to this.
|
CC @alan-j-hu just FYI |
kit-ty-kate
reviewed
Apr 17, 2023
|
|
||
| if llvm_config --link-shared --libs; then | ||
| default_mode=shared | ||
| default_mode=${default_mode:=shared} |
There was a problem hiding this comment.
Suggested change
| default_mode=${default_mode:=shared} |
| support_shared_mode=true | ||
| fi | ||
|
|
||
| if llvm_config --link-static --libs; then | ||
| default_mode=${default_mode:=static} |
There was a problem hiding this comment.
Suggested change
| default_mode=${default_mode:=static} |
| if test -z "$default_mode"; then | ||
| echo "Something is wrong with the llvm-config command provided." | ||
| exit 1 | ||
| fi | ||
|
|
||
| base_cflags=$(llvm_config --cflags) | ||
| ldflags="$(llvm_config --ldflags) -lstdc++" | ||
| ldflags="$(pkg-config --libs-only-L libzstd) $(llvm_config --ldflags) -lstdc++" |
There was a problem hiding this comment.
Suggested change
| ldflags="$(pkg-config --libs-only-L libzstd) $(llvm_config --ldflags) -lstdc++" | |
| ldflags="$(llvm_config --link-static --system-libs --ldflags) -lstdc++" |
Comment on lines
43
to
46
| if test -z "$default_mode"; then | ||
| echo "Something is wrong with the llvm-config command provided." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if test -z "$default_mode"; then | |
| echo "Something is wrong with the llvm-config command provided." | |
| exit 1 | |
| fi | |
| if test "(" "${default_mode}" = static -a "${support_static_mode}" = false ")" -o \ | |
| "(" "${default_mode}" = shared -a "${support_shared_mode}" = false ")" ; then | |
| echo "Mode '${default_mode}' unsupported." | |
| exit 1 | |
| fi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not worked through diligently enough to merge in its current
state, I'm just sending this PR to share an idea of how to let client
projects specify the desired linking mode to use.