Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacky Lib Conversion #313

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Hacky Lib Conversion #313

wants to merge 10 commits into from

Conversation

Kakapio
Copy link

@Kakapio Kakapio commented Aug 26, 2024

Primary issues:

  1. CLI config serialization had to be stripped out since that wasn't needed for a library crate.
  2. The blocking run-time was a pain so in production I just spawn a blocking tokio task whenever this crate is called.

@alanvardy
Copy link
Owner

Hi @Kakapio , I am currently unable to address this PR, I am transitioning to a new career and won't have the time for a while.

I recommend forking this repo or perhaps "vendoring" the needed code. When I have time in the future I would love to extract out a "liblnr" library that could be used by this lnr library and anyone else who needs it.

@Kakapio
Copy link
Author

Kakapio commented Aug 30, 2024

Hey Alan,

I already forked it and am using it. It's a useful crate. No worries, good luck with the career change!

Thank you,
Kakapio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants